add debug alias for let #1631
Open
add debug alias for let #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any ideas an the perf check failing? (It's failing on all branches) We can't really merge anything until that's fixed :( |
patricklx
force-pushed
the
add-debug-alias-for-let
branch
2 times, most recently
from
0025c4a
to
8730a06
Compare
NullVoxPopuli
force-pushed
the
add-debug-alias-for-let
branch
from
8730a06
to
f8ce3f3
Compare
NullVoxPopuli
dismissed
their stale review
Dismissing because we want to go more in a direction that exposes what the user typed, rather than try to derive debug aliases / names from existing runtime information --- here is an example: #1634 -- @wycats is currently thinking about this PR and is actively workingish on it -- this way when folks import something and alias it, we use the alias name, rather than the name it was defined with (current behavior as implemented)
|
@wycats i saw you are working on this. Maybe this us already fixed? |
|
Btw, this is not derived debug alias, but the actual debug symbol what the user typed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps especially on cases for e.g.
When one has a let var which collides with a html element